lkml.org 
[lkml]   [2015]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3/3] tools lib traceevent: Add support for __print_array()
On Fri, Feb 27, 2015 at 02:15:05PM +0000, Steven Rostedt wrote:
> On Fri, 27 Feb 2015 12:32:32 +0000
> Javi Merino <javi.merino@arm.com> wrote:
>
> > Hi Steve,
> >
> > On Wed, Jan 28, 2015 at 12:48:55PM +0000, Javi Merino wrote:
> > > Trace can now generate traces with variable element size arrays. Add
> > > support to parse them.
> > >
> > > Cc: Namhyung Kim <namhyung@kernel.org>
> > > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > Cc: Steven Rostedt <rostedt@goodmis.org>
> > > Cc: Jiri Olsa <jolsa@redhat.com>
> > > Signed-off-by: Javi Merino <javi.merino@arm.com>
> > > ---
> > > tools/lib/traceevent/event-parse.c | 93 ++++++++++++++++++++++++++++++++++++++
> > > tools/lib/traceevent/event-parse.h | 8 ++++
> > > 2 files changed, 101 insertions(+)
> >
> > I've seen that patch 1 of this series is now in mainline. What about
> > patches 2 and 3 (the updates to tools/lib/traceevent)? Shall I resend
> > them?
>
> Patches 2 and 3 are in tools/lib and need to go through Jiri and
> Arnaldo. Please repost them again. I can give them acks.

Cool, done.

> > These two patches should also be applied to trace-cmd. Do you want me
> > to send patches for that to linux-kernel or will you take care of
> > applying them there?
>
> No need, I can pull them from here. I just been a bit busy to do so.

No worries. I was just unsure about the process.
> >
> > Incidentally, why are there two copies of libtraceevent? Shouldn't
> > this live only in one place (either kernel or trace-cmd)?
>
> Actually, libtraceevent does not exist in trace-cmd, just the event
> parsing code.

Right, that's what I meant. I was wondering about the duplicated
code.

Thanks,
Javi


\
 
 \ /
  Last update: 2015-02-27 16:01    [W:0.079 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site