lkml.org 
[lkml]   [2015]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ocfs2: remove unneeded variable 'status'
On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn <daeseok.youn@gmail.com> wrote:

> Use 'retval' instead of 'status'.
>

The patch does a lot more than this. It causes __ocfs2_add_entry to
propagate error codes which were previously dropped on the floor.

Please update the changelog to fully explain the functional changes and
to explain why they are desirable.

After the patch there is still one unchecked call to
ocfs2_journal_access_di() and one unchecked call to
ocfs2_journal_access_db(). Probably these are bugs.



\
 
 \ /
  Last update: 2015-02-26 22:41    [W:0.050 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site