lkml.org 
[lkml]   [2015]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [perf/core PATCH v5 4/4] perf-buildid-cache: Show usage with incorrect params
Em Thu, Feb 26, 2015 at 03:55:01PM +0900, Masami Hiramatsu escreveu:
> Show usage if no action is specified or unexpected parameter
> is given. In other words, be more user friendly.

Thanks for doing that!

Doesn't apply due to previous patches being delayer at the moment.

- Arnaldo

> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> ---
> tools/perf/builtin-buildid-cache.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c
> index 20be743..5eaa9bf 100644
> --- a/tools/perf/builtin-buildid-cache.c
> +++ b/tools/perf/builtin-buildid-cache.c
> @@ -340,6 +340,11 @@ int cmd_buildid_cache(int argc, const char **argv,
> argc = parse_options(argc, argv, buildid_cache_options,
> buildid_cache_usage, 0);
>
> + if (argc || (!add_name_list_str && !kcore_filename &&
> + !remove_name_list_str && !purge_name_list_str &&
> + !missing_filename && !update_name_list_str))
> + usage_with_options(buildid_cache_usage, buildid_cache_options);
> +
> if (missing_filename) {
> file.path = missing_filename;
> file.force = force;
>


\
 
 \ /
  Last update: 2015-02-26 16:41    [W:0.090 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site