Messages in this thread Patch in this message | | | Date | Thu, 26 Feb 2015 11:46:33 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH perf/core ] [BUGFIX] perf-probe: Fix get_real_path to free allocated memory in error path |
| |
Em Thu, Feb 26, 2015 at 05:25:04PM +0900, Masami Hiramatsu escreveu: > Fix get_real_path to free allocated memory when comp_dir > is used for complementing path and getting an error.
While reviewing this patch I noticed this is needed, ack?
- Arnaldo
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 4a93bf433344..9526cf37682e 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -533,7 +533,7 @@ static int get_real_path(const char *raw_path, const char *comp_dir, else { if (access(raw_path, R_OK) == 0) { *new_path = strdup(raw_path); - return 0; + return *new_path ? 0 : -ENOMEM; } else return -errno; }
| |