Messages in this thread | | | From | Denys Vlasenko <> | Date | Thu, 26 Feb 2015 15:13:26 +0100 | Subject | Re: [PATCH 4/7] x86: entry.S: use JZ mnemonic after TEST, not JE |
| |
On Thu, Feb 26, 2015 at 12:04 AM, Borislav Petkov <bp@alien8.de> wrote: > On Wed, Feb 25, 2015 at 01:00:16AM +0100, Denys Vlasenko wrote: >> After TEST insn, JE actually performs "jump if zero", >> let's use JZ mnemonic instead. >> >> No code changes, but less confusion. >> >> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> >> CC: Linus Torvalds <torvalds@linux-foundation.org> >> CC: Steven Rostedt <rostedt@goodmis.org> >> CC: Ingo Molnar <mingo@kernel.org> >> CC: Borislav Petkov <bp@alien8.de> >> CC: "H. Peter Anvin" <hpa@zytor.com> >> CC: Andy Lutomirski <luto@amacapital.net> >> CC: Oleg Nesterov <oleg@redhat.com> >> CC: Frederic Weisbecker <fweisbec@gmail.com> >> CC: Alexei Starovoitov <ast@plumgrid.com> >> CC: Will Drewry <wad@chromium.org> >> CC: Kees Cook <keescook@chromium.org> >> CC: x86@kernel.org >> CC: linux-kernel@vger.kernel.org >> --- >> arch/x86/kernel/entry_64.S | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Borislav Petkov <bp@suse.de>
Andy, please don't take this patch yet, there are about a dozen more instances of TEST which need similar treatment.
| |