lkml.org 
[lkml]   [2015]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support
On Mon, Feb 16, 2015 at 09:19:49AM +0100, Javier Martinez Canillas wrote:
> Hello Olof,
>
> On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote:
> > Hello,
> >
> > The mainline ChromeOS Embedded Controller (EC) driver is still missing some
> > features that are present in the downstream ChromiumOS tree. These are:
> >
> > - Low Pin Count (LPC) interface
> > - User-space device interface
> > - Access to vboot context stored on a block device
> > - Access to vboot context stored on EC's nvram
> > - Power Delivery Device
> > - Support for multiple EC in a system
> >
> > This is a fifth version of a series that adds support for the first two of
> > the missing features: the EC LPC and EC character device interfaces that
> > are used by user-space to access the ChromeOS EC. The support patches were
> > taken from the downstream ChromiumOS 3.14 tree with the fixes and cleanups
> > squashed to have a minimal patch-set.
> >
>
> Any comments on this series? The last version was posted a couple of weeks
> ago but the series have been in the list for months. Lee has already acked
> the mfd changes so you can merge all through your chrome-platform tree if
> you want.
>
> It wold be great if this series get in to have the EC user-space interface
> supported and to minimize the delta with the Chromemium OS kernel since it
> still has other features that needs to be upstreamed like multiple EC in a
> system and access to vboot context stored in block device or EC's nvram.

Yeah, sorry for dragging my feet on this. The only thing I found that should
should be revisited is the reuse of the ioctl numbers to make it easier to
transition on the Chrome OS side -- otherwise it'll be hard to know from
userspace to use old or new structs during transition without a flag day.


-Olof


\
 
 \ /
  Last update: 2015-02-26 02:01    [W:0.194 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site