Messages in this thread | | | Date | Wed, 25 Feb 2015 13:09:24 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH 2/2] cpusets,isolcpus: add file to show isolated cpus in cpuset |
| |
On Wed, 25 Feb 2015, riel@redhat.com wrote:
> diff --git a/kernel/cpuset.c b/kernel/cpuset.c > index b544e5229d99..94bf59588e23 100644 > --- a/kernel/cpuset.c > +++ b/kernel/cpuset.c > @@ -1563,6 +1563,7 @@ typedef enum { > FILE_MEMORY_PRESSURE, > FILE_SPREAD_PAGE, > FILE_SPREAD_SLAB, > + FILE_ISOLCPUS, > } cpuset_filetype_t; > > static int cpuset_write_u64(struct cgroup_subsys_state *css, struct cftype *cft, > @@ -1704,6 +1705,20 @@ static ssize_t cpuset_write_resmask(struct kernfs_open_file *of, > return retval ?: nbytes; > } > > +static void cpuset_seq_print_isolcpus(struct seq_file *sf, struct cpuset *cs) > +{ > + cpumask_var_t my_isolated_cpus; > + > + if (!alloc_cpumask_var(&my_isolated_cpus, GFP_KERNEL)) > + return; > + > + cpumask_and(my_isolated_cpus, cs->cpus_allowed, cpu_isolated_map); > + > + seq_printf(sf, "%*pbl\n", nodemask_pr_args(my_isolated_cpus));
That unfortunately won't output anything, it needs to be cpumask_pr_args(). After that's fixed, feel free to add my
Acked-by: David Rientjes <rientjes@google.com>
> + > + free_cpumask_var(my_isolated_cpus); > +} > + > /* > * These ascii lists should be read in a single call, by using a user > * buffer large enough to hold the entire map. If read in smaller > @@ -1733,6 +1748,9 @@ static int cpuset_common_seq_show(struct seq_file *sf, void *v) > case FILE_EFFECTIVE_MEMLIST: > seq_printf(sf, "%*pbl\n", nodemask_pr_args(&cs->effective_mems)); > break; > + case FILE_ISOLCPUS: > + cpuset_seq_print_isolcpus(sf, cs); > + break; > default: > ret = -EINVAL; > } > @@ -1893,6 +1911,12 @@ static struct cftype files[] = { > .private = FILE_MEMORY_PRESSURE_ENABLED, > }, > > + { > + .name = "isolcpus", > + .seq_show = cpuset_common_seq_show, > + .private = FILE_ISOLCPUS, > + }, > + > { } /* terminate */ > }; >
| |