Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/1] serial: 8250_dw: Fix get_mctrl behaviour | Date | Wed, 25 Feb 2015 20:21:25 +0100 |
| |
On Wednesday 25 February 2015 11:04:16 Jonathan Richardson wrote: > +- msr-override : array of strings to be used to override the individual > + modem status signals for DCD, DSR, CTS, and RI. If the property is not > + present, the individual signals are obtained from the modem status register. > + Strings accepted are "dcd", "dsr", "cts", and "ri". If "dcd", "dsr", or > + "cts" are present, these signals will always be reported as active. If > + "ri" is present, this signal will always be reported as inactive. >
Did you copy this definition from another driver? If not, we should try to come up with a more natural way to do it. How about defining four boolean properties instead, like
dcd-override dsr-override cts-override ri-override
Simplifies the parser and the binding.
Arnd
| |