lkml.org 
[lkml]   [2015]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] serial: 8250_dw: Fix get_mctrl behaviour
Date
On Wednesday 25 February 2015 11:04:16 Jonathan Richardson wrote:
> +- msr-override : array of strings to be used to override the individual
> + modem status signals for DCD, DSR, CTS, and RI. If the property is not
> + present, the individual signals are obtained from the modem status register.
> + Strings accepted are "dcd", "dsr", "cts", and "ri". If "dcd", "dsr", or
> + "cts" are present, these signals will always be reported as active. If
> + "ri" is present, this signal will always be reported as inactive.
>

Did you copy this definition from another driver? If not, we should try
to come up with a more natural way to do it. How about defining four
boolean properties instead, like

dcd-override
dsr-override
cts-override
ri-override

Simplifies the parser and the binding.

Arnd


\
 
 \ /
  Last update: 2015-02-25 20:41    [W:0.060 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site