Messages in this thread | | | Date | Wed, 25 Feb 2015 12:21:53 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/7] x86/intel_rdt: Intel Cache Allocation Technology detection |
| |
On Tue, Feb 24, 2015 at 04:42:10PM -0800, Vikas Shivappa wrote: > >>+ > >>+ pr_info("cbmlength:%u,Closs: %u\n", cbm_len, maxid); > > > >This text message needs to be much more user-friendly if it is going out > >to the console unconditionally. > > > > bit mask lengh: number of CLOSids: ? . it should print with the module name > as well which should help understand what it is for.
Right, if I haven't read the SDM on RDT, I still don't understand what those mean. What is the need for that message at all, what is it telling me?
Can you show an example from a machine with RDT and explain what it is good for?
> >>+config CGROUP_RDT > >>+ bool "Resource Director Technology cgroup subsystem" > >>+ depends on X86_64 > > > >depends on X86_64 && CPU_SUP_INTEL > > > >Also, this should probably also depend on CGROUP-something or so > >AFAICT... > > This is with in the if CGROUPS
Right, but you still need the CPU_SUP_INTEL dependency as !Intel x86 doesn't need that code built.
Thanks.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |