Messages in this thread | | | Date | Mon, 23 Feb 2015 13:23:21 +0100 | From | Andreas Färber <> | Subject | Re: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling |
| |
Hi,
Am 23.02.2015 um 09:29 schrieb Javier Martinez Canillas: > On 02/20/2015 04:27 AM, Tushar Behera wrote: >> On 02/20/2015 12:48 AM, Andreas Färber wrote: >>> If master clock is provided through device tree, then update >>> the master clock frequency during set_sysclk. >>> >>> Cc: Tushar Behera <tushar.behera@linaro.org> >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> --- >>> sound/soc/codecs/max98088.c | 24 ++++++++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >>> >> >> Looks good. >> >> Acked-by: Tushar Behera <trblinux@gmail.com> >> > > Looks good to me as well. > > Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Thanks guys. One self-doubt: Is there any downside to returning -EPROBE_DEFER after regcache_mark_dirty(max98088->regmap)? I.e., should I move the last hunk some lines up to be the very first thing executed?
Cheers, Andreas
-- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)
| |