lkml.org 
[lkml]   [2015]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)
    From
    Date
    On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote:
    > On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
    > > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
    > > > As always, comments are welcome.
    > >
    > > Are nits welcome too?
    > >
    > > > +MODULE_LICENSE("GPLv2");
    > >
    > > You probably meant
    > > MODULE_LICENSE("GPL v2")
    > >
    > > Didn't that trigger a warning or error?
    >
    > checkpatch showed no warning about that, not even with --strict option.
    > I believe both ways are fine. But I can add the space.

    "GPLv2" is not mentioned in include/linux/license.h so, as I remember,
    it would taint the kernel, and a warning will be printed when you load
    that module.

    Thanks,


    Paul Bolle



    \
     
     \ /
      Last update: 2015-02-20 20:41    [W:3.284 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site