lkml.org 
[lkml]   [2015]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr
From
Date
On Thu, 2015-02-19 at 21:28 -0800, Darren Hart wrote:
> On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote:
>
> Commit message please.

Added.

> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > ---
> > drivers/platform/x86/thinkpad_acpi.c | 71 +++++++++++++++++++++++++++++++-----
> > 1 file changed, 62 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> > index a6dd017..562d958 100644
> > --- a/drivers/platform/x86/thinkpad_acpi.c
> > +++ b/drivers/platform/x86/thinkpad_acpi.c
>
> ...
>
> > +static struct device_attribute dev_attr_adaptive_kbd_mode =
> > + __ATTR(adaptive_kbd_mode, S_IWUSR | S_IRUGO,
> > + adaptive_kbd_mode_show, adaptive_kbd_mode_store);
> > +
>
> Please use DEVICE_ATTR_RW() macros for new sysfs files.

Done.

> I'd very much like to see a cleanup of the driver to use these as well.
>
> Henrique, your thoughts / preference?

Looks easy enough. I'll post the patch with the new series.



\
 
 \ /
  Last update: 2015-02-20 16:01    [W:0.043 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site