lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1 linux-next] fs/ufs/super.c: remove CONFIG_SMP/CONFIG_PREEMPT testing
On Sun,  1 Feb 2015 12:36:57 +0100 Fabian Frederick <fabf@skynet.be> wrote:

> Let locking subsystem decide on mutex management.
>
> ...
>
> --- a/fs/ufs/super.c
> +++ b/fs/ufs/super.c
> @@ -95,22 +95,18 @@
>
> void lock_ufs(struct super_block *sb)
> {
> -#if defined(CONFIG_SMP) || defined (CONFIG_PREEMPT)
> struct ufs_sb_info *sbi = UFS_SB(sb);
>
> mutex_lock(&sbi->mutex);
> sbi->mutex_owner = current;
> -#endif
> }

Good heavens.

This patch is a bugfix. lock_ufs() is assuming that on non-preempt
uniprocessor, the calling code will run atomically up to the matching
unlock_ufs().

But that isn't true. The very first site I looked at (ufs_frag_map)
does sb_bread() under lock_ufs(. And sb_bread() will call schedule(),
very commonly.

The ->mutex_owner stuff is a bit hacky but should work OK.

Care to resend the patch with a more alarming changelog?


\
 
 \ /
  Last update: 2015-02-03 01:21    [W:0.050 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site