lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] f2fs: don't trigger recovery for normal umount image
Hi Chao,

On Sat, Jan 31, 2015 at 04:59:49PM +0800, Chao Yu wrote:
> Our recovery option is on by default, so we will try to recover data for
> a normally umounted image when mounting it, but no data will be recovered.
>
> So it'd be better to skip the recovery for above condition.

No.
We should consider the existing UMOUNT flag written by old f2fs.

Thanks,

>
> Signed-off-by: Chao Yu <chao2.yu@samsung.com>
> ---
> fs/f2fs/recovery.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
> index 188a034..c80c286 100644
> --- a/fs/f2fs/recovery.c
> +++ b/fs/f2fs/recovery.c
> @@ -500,6 +500,9 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
> int err;
> bool need_writecp = false;
>
> + if (is_set_ckpt_flags(sbi->ckpt, CP_UMOUNT_FLAG))
> + return 0;
> +
> fsync_entry_slab = f2fs_kmem_cache_create("f2fs_fsync_inode_entry",
> sizeof(struct fsync_inode_entry));
> if (!fsync_entry_slab)
> --
> 2.2.1


\
 
 \ /
  Last update: 2015-02-03 01:01    [W:0.124 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site