Messages in this thread | | | From | Tim Sander <> | Subject | Re: [PATCH] 3.19-rc7: add quirk for 1c28:0122 (rev 14) SATA controller | Date | Mon, 02 Feb 2015 21:15:22 +0100 |
| |
Hi Bjorn
Am Montag 02 Februar 2015, 08:55:33 schrieb Bjorn Helgaas: > [+cc Alex] > > On Mon, Feb 2, 2015 at 5:29 AM, Tim Sander <tim@krieglstein.org> wrote: > > The long name for this device is > > Lite-On IT Corp. / Plextor M6e PCI Express SSD [Marvell 88SS9183] (rev 14) > > > > Background: the error description on bugzilla > > https://bugzilla.kernel.org/show_bug.cgi?id=42679 > > inspired me to check if my brand new m4 pci ssd could work with a quirk. > > Its device representation is not visible before this patch. > > After this patch it appears as a normal device. Formatting > > and mounting worked so far. > > > > Signed-off-by: Tim Sander <tim@krieglstein.org> > > Hi Tim, > > Thanks a lot for the patch. Can you open a new report at > http://bugzilla.kernel.org and attach the complete dmesg and "lspci > -vv" output without this patch, and also a dmesg log *with* this > patch? I like to keep a little documentation around in case we > restructure this code in the future. Basically its the same issue as the linked bug report, so reporting this twice seems a little backward to me?
> Also, since the vendor and device IDs are used only once, we probably > won't add them to pci_ids.h (see the comment at the top of the file). > Just use the bare constants in the quirk.
Mh, thats what i had first. For patch submission i created the header entries as it seemed cleaner as you can deduce the manufacturer from the names. But then its really not that important.
Tim
| |