lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [GIT PULL] aio: fix sleeping while TASK_INTERRUPTIBLE
From
On Sun, Feb 1, 2015 at 9:54 PM, Dave Chinner <david@fromorbit.com> wrote:
>
> Simple enough - the patch below removes the warning from generic/036
> for me.

So because this is a debugging thing, I'd actually prefer these
"sched_annotate_sleep()" calls to always come with short comments in
code why they exist and why they are fine.

In this case, it might be as simple as

"If the mutex blocks and wakes us up, the loop in
wait_event_interruptible_hrtimeout() will just schedule without
sleeping and repeat. The ting-lock doesn't block often enough for this
to be a performance issue".

or perhaps just point to the comment in read_events().

Linus


\
 
 \ /
  Last update: 2015-02-02 20:01    [W:0.328 / U:2.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site