Messages in this thread | | | Date | Mon, 2 Feb 2015 10:45:42 -0800 | Subject | Re: [GIT PULL] aio: fix sleeping while TASK_INTERRUPTIBLE | From | Linus Torvalds <> |
| |
On Sun, Feb 1, 2015 at 9:54 PM, Dave Chinner <david@fromorbit.com> wrote: > > Simple enough - the patch below removes the warning from generic/036 > for me.
So because this is a debugging thing, I'd actually prefer these "sched_annotate_sleep()" calls to always come with short comments in code why they exist and why they are fine.
In this case, it might be as simple as
"If the mutex blocks and wakes us up, the loop in wait_event_interruptible_hrtimeout() will just schedule without sleeping and repeat. The ting-lock doesn't block often enough for this to be a performance issue".
or perhaps just point to the comment in read_events().
Linus
| |