Messages in this thread | | | Date | Mon, 2 Feb 2015 11:56:38 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regmap: Fix i2c word access when using SMBus access functions |
| |
On Mon, Feb 02, 2015 at 11:26:23AM +0100, Lars-Peter Clausen wrote: > On 02/02/2015 12:48 AM, Guenter Roeck wrote:
> >- return ®map_smbus_word; > >+ if (config->val_format_endian == REGMAP_ENDIAN_LITTLE)
> This should probably use regmap_get_val_endian() and maybe also handle > REGMAP_ENDIAN_NATIVE.
Yes, we really ought to handle _NATIVE too (though the chances of it being used with I2C are minimal, it's mostly for MMIO). This also feels like it's something that should be being handled further up the stack in the serialization code but given that there's direct functions for this in the smbus code perhaps it's better here. Or perhaps the smbus support ought to be transitioned to use the bus interface and set reg_write() and reg_read() operations now that we can do that, it seems like a better fit though it might break compatibility with wierd devices. [unhandled content-type:application/pgp-signature] | |