lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v3 2/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_free"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 2 Feb 2015 10:40:30 +0100

    The cipso_v4_doi_free() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    Acked-by: Paul Moore <paul@paul-moore.com>
    ---
    net/netlabel/netlabel_cipso_v4.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/net/netlabel/netlabel_cipso_v4.c b/net/netlabel/netlabel_cipso_v4.c
    index 1796253..7fd1104 100644
    --- a/net/netlabel/netlabel_cipso_v4.c
    +++ b/net/netlabel/netlabel_cipso_v4.c
    @@ -324,8 +324,7 @@ static int netlbl_cipsov4_add_std(struct genl_info *info,
    return 0;

    add_std_failure:
    - if (doi_def)
    - cipso_v4_doi_free(doi_def);
    + cipso_v4_doi_free(doi_def);
    return ret_val;
    }

    --
    2.2.2


    \
     
     \ /
      Last update: 2015-02-02 11:41    [W:2.118 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site