Messages in this thread | | | Date | Mon, 2 Feb 2015 10:08:09 +0100 | From | Nicholas Mc Guire <> | Subject | Re: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling |
| |
On Mon, 02 Feb 2015, Laxman Dewangan wrote:
> On Sunday 01 February 2015 06:30 PM, Nicholas Mc Guire wrote: >> return type of wait_for_completion_timeout is unsigned long not int, this >> patch adds an appropriate variable and fixes up the assignment. >> As the string in dev_err already states "timeout" there >> is little point in printing the 0 here. >> >> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> > > Looks good to me. Thanks for fixing this. > I think it is good if we fix the typo here also. > > Acked-by: Laxman Dewangan <ldewangan@nvidia.com> > >> >> + if (WARN_ON(dma_timeout == 0)) { >> dev_err(tsd->dev, >> - "spi trasfer timeout, err %d\n", ret); >> + "spi trasfer timeout\n"); > > trasfer -> transfer. > > overlooked that - sorry - will fix it up and resubmit.
thx! hofrat
| |