lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] spi: tegra20-sflash: cleanup wait_for_completion return handling
On Mon, 02 Feb 2015, Laxman Dewangan wrote:

> On Sunday 01 February 2015 06:30 PM, Nicholas Mc Guire wrote:
>> return type of wait_for_completion_timeout is unsigned long not int, this
>> patch adds an appropriate variable and fixes up the assignment.
>> As the string in dev_err already states "timeout" there
>> is little point in printing the 0 here.
>>
>> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
>
> Looks good to me. Thanks for fixing this.
> I think it is good if we fix the typo here also.
>
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
>
>>
>> + if (WARN_ON(dma_timeout == 0)) {
>> dev_err(tsd->dev,
>> - "spi trasfer timeout, err %d\n", ret);
>> + "spi trasfer timeout\n");
>
> trasfer -> transfer.
>
>
overlooked that - sorry - will fix it up and resubmit.

thx!
hofrat


\
 
 \ /
  Last update: 2015-02-02 10:41    [W:0.031 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site