Messages in this thread | | | Date | Mon, 2 Feb 2015 14:33:05 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 2/2] spi: tegra20-slink: cleanup wait_for_completion return handling |
| |
On Sunday 01 February 2015 06:32 PM, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int, this > patch adds an appropriate variable and fixes up the assignment. > As the string in dev_err already states "timeout" there is little point in > printing the 0 here as it just restates "timeout". Looks good to me. Thanks for fixing this. I think it is good if we fix the typo here also.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
> - if (WARN_ON(ret == 0)) { > - dev_err(tspi->dev, > - "spi trasfer timeout, err %d\n", ret); > + if (WARN_ON(dma_timeout == 0)) { > + dev_err(tspi->dev, "spi trasfer timeout\n"); trasfer->transfer
| |