Messages in this thread | | | From | Pali Rohár <> | Subject | Re: [PATCH] dell-laptop: use dedicated sysfs file for ALS | Date | Wed, 18 Feb 2015 20:09:28 +0100 |
| |
On Friday 13 February 2015 15:30:42 Gabriele Mazzotta wrote: > On Tuesday 10 February 2015 10:36:21 Pali Rohár wrote: > > On Wednesday 14 January 2015 15:05:57 Gabriele Mazzotta wrote: > > > The ambient light sensor doesn't act like an input > > > trigger, so it has to be kept separate. The sensor > > > readings are used to determine whether the conditions to > > > change the keyboard illumination are satisfied or not the > > > moment an input trigger is used. Ambient light changes > > > alone can't change the keyboard backlight illumination > > > and don't restart the timer. > > > > > > Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com> > > > --- > > > > Gabriele, can you look and integrate this patch into full > > keyboard backlight support? Ideally send new full one... > > I will do that soon. > > Darren, do you prefer one single patch or should I send Pali's > patch and my changes in different patches (that can be later > squashed) to make the review easier?
Gabriele, I think you should send patch now. Just integrate all changes to one (this could be easy) and send it.
-- Pali Rohár pali.rohar@gmail.com [unhandled content-type:application/pgp-signature] | |