Messages in this thread Patch in this message | | | Date | Wed, 18 Feb 2015 09:13:06 -0800 | From | tip-bot for Shaohua Li <> | Subject | [tip:perf/core] perf: Update shadow timestamp before add event |
| |
Commit-ID: 72f669c0086fbbbbebc92ce7390125722c4c0ec5 Gitweb: http://git.kernel.org/tip/72f669c0086fbbbbebc92ce7390125722c4c0ec5 Author: Shaohua Li <shli@fb.com> AuthorDate: Thu, 5 Feb 2015 15:55:31 -0800 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Wed, 18 Feb 2015 17:01:44 +0100
perf: Update shadow timestamp before add event
Update the shadow timestamp before start event, because .add might use the timestamp.
Signed-off-by: Shaohua Li <shli@fb.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Paul Mackerras <paulus@samba.org> Link: http://lkml.kernel.org/r/9cd0276d6a047cb7c2885994f25e3a1f7c8c28af.1423180257.git.shli@fb.com Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/events/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c index 13209a9..e580e0f 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -1881,6 +1881,10 @@ event_sched_in(struct perf_event *event, perf_pmu_disable(event->pmu); + event->tstamp_running += tstamp - event->tstamp_stopped; + + perf_set_shadow_time(event, ctx, tstamp); + if (event->pmu->add(event, PERF_EF_START)) { event->state = PERF_EVENT_STATE_INACTIVE; event->oncpu = -1; @@ -1888,10 +1892,6 @@ event_sched_in(struct perf_event *event, goto out; } - event->tstamp_running += tstamp - event->tstamp_stopped; - - perf_set_shadow_time(event, ctx, tstamp); - if (!is_software_event(event)) cpuctx->active_oncpu++; if (!ctx->nr_active++)
| |