Messages in this thread | | | Date | Tue, 17 Feb 2015 16:15:48 +0200 | From | Roger Quadros <> | Subject | Re: [PATCH 4/4] ARM OMAP2+ GPMC: add bus children |
| |
On 17/02/15 15:57, Robert Abel wrote: > Hi Roger, > > On Tue, Feb 17, 2015 at 10:41 AM, Roger Quadros <rogerq@ti.com> wrote:> >> Can we simply use only >> of_platform_populate(child, NULL, NULL, &pdev->dev) >> >> That way we get rid of the if..else and let OF core take care of >> creating buses or devices. > > Surely, you mean > >> of_platform_populate(child, of_default_bus_match_table, NULL, &pdev->dev); > > ? If matches is NULL, we won't match any busses. Or did you mean to > just replace the second conditional?
I was wondering if just one call to of_platform_populate() is sufficient. so you probably need "of_default_bus_match_table" for matches.
> > I'll try that and see it works. >
cheers, -roger
| |