lkml.org 
[lkml]   [2015]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] extcon: arizona: Deobfuscate arizona_extcon_do_magic
From
Hi Charles,


On Tue, Feb 17, 2015 at 12:41 AM, Charles Keepax
<ckeepax@opensource.wolfsonmicro.com> wrote:
> arizona_extcon_do_magic does not lend a lot of clarity to the purpose
> of the function, and as all the registers used are described in the
> datasheet there is no need to obfuscate the code. This patch renames the
> function to arizona_extcon_hp_clamp, as it controls clamping on the
> headphone output.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> drivers/extcon/extcon-arizona.c | 36 ++++++++++++++++++++----------------
> include/linux/mfd/arizona/core.h | 2 +-
> sound/soc/codecs/arizona.c | 4 ++--
> 3 files changed, 23 insertions(+), 19 deletions(-)


Looks good to me.
But, you need more ack message by MFD maintainer.

For extcon part:
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks,
Chanwoo Choi


\
 
 \ /
  Last update: 2015-02-16 18:01    [W:0.065 / U:1.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site