Messages in this thread | | | Date | Fri, 13 Feb 2015 08:23:03 +0100 | From | Javier Martinez Canillas <> | Subject | Re: [PATCH v2 3/3] clk: Replace explicit clk assignment with __clk_hw_set_clk |
| |
Hello Stephen,
On 02/12/2015 08:55 PM, Stephen Boyd wrote: > On 02/12/15 05:58, Javier Martinez Canillas wrote: >> >> The changes were made using the following cocinelle semantic patch: >> >> @i@ >> @@ >> >> @depends on i@ >> identifier dst; >> @@ >> >> - dst->clk = hw->clk; >> + __clk_hw_set_clk(dst, hw); >> >> @depends on i@ >> identifier dst; >> @@ >> >> - dst->hw.clk = hw->clk; >> + __clk_hw_set_clk(&dst->hw, hw); >> >> Fixes: 035a61c314eb3 ("clk: Make clk API return per-user struct clk instances") >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> >
Thanks a lot for your review.
> Did you run this on all files that include clk-provider.h? I hope there > aren't similar situations in arch/arm/ for example. >
Yes, I did run spatch against all the files that include clk-provider.h but only were matches in the drivers/clk files changed by $subject.
Best regards, Javier
| |