lkml.org 
[lkml]   [2015]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/4] scsi: ufs: add trace events and dump prints for debug
    On Tue, 10 Feb 2015 15:58:54 +0200
    Gilad Broner <gbroner@codeaurora.org> wrote:

    I really hate large patches like this. So much to dig through.

    > -#ifdef CONFIG_DEBUG_FS
    > +#define UIC_ERR_REG_HIST_LENGTH 8
    > +/**
    > + * struct ufs_uic_err_reg_hist - keeps history of uic errors
    > + * @pos: index to indicate cyclic buffer position
    > + * @reg: cyclic buffer for registers value
    > + * @tstamp: cyclic buffer for time stamp
    > + */
    > +struct ufs_uic_err_reg_hist {
    > + int pos;
    > + u32 reg[UIC_ERR_REG_HIST_LENGTH];
    > + ktime_t tstamp[UIC_ERR_REG_HIST_LENGTH];
    > +};
    > +
    > +/**
    > + * struct ufs_stats - keeps usage/err statistics
    > + * @enabled: enable tagstats for debugfs
    > + * @tag_stats: pointer to tag statistic counters
    > + * @q_depth: current amount of busy slots
    > + * @err_stats: counters to keep track of various errors
    > + * @hibern8_exit_cnt: Counter to keep track of number of exits,
    > + * reset this after link-startup.
    > + * @last_hibern8_exit_tstamp: Set time after the hibern8 exit.
    > + * Clear after the first successful command completion.
    > + * @pa_err: tracks pa-uic errors
    > + * @dl_err: tracks dl-uic errors
    > + * @nl_err: tracks nl-uic errors
    > + * @tl_err: tracks tl-uic errors
    > + * @dme_err: tracks dme errors
    > + */
    > struct ufs_stats {
    > +#ifdef CONFIG_DEBUG_FS
    > bool enabled;
    > u64 **tag_stats;
    > int q_depth;
    > int err_stats[UFS_ERR_MAX];
    > +#endif

    Can any of the tracepoint code be called that references these when
    CONFIG_DEBUG_FS is not set? Because soon (possibly even this merge
    window), tracing will no longer depend on DEBUG_FS, because it will
    have its own filesystem.

    -- Steve



    \
     
     \ /
      Last update: 2015-02-12 21:01    [W:8.500 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site