Messages in this thread | | | Date | Thu, 12 Feb 2015 09:45:38 +0100 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 03/16] tty: serial: 8250_core: read only RX if there is something in the FIFO |
| |
On 02/11/2015 09:42 PM, Peter Hurley wrote:
>> Reverting makes sense to me if it has caused a regression. Maybe Sebastian >> can update his patch to do this based on some quirk flag instead? > > That's fine with me. There's a 'bugs' field in struct 8250_uart_port and > UART_BUG_* defines in 8250/8250.h for that purpose.
Makes sense. Reading an empty FIFO does not look right. Maybe we should do the bug flag the other way around? But I can do what I am told to so if there is more fallout than just this Marvell UART I could come around with a patch to the bug field for the older OMAP.
> Regards, > Peter Hurley
Sebastian
| |