Messages in this thread | | | From | Andy Lutomirski <> | Date | Wed, 11 Feb 2015 12:40:36 -0800 | Subject | Re: [PATCH 08/11] x86: entry_64.S: fold test_in_nmi macro into its only user |
| |
On Wed, Jan 14, 2015 at 1:48 PM, Denys Vlasenko <dvlasenk@redhat.com> wrote: > No code changes.
Steven, is this okay with you?
--Andy
> > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> > CC: Linus Torvalds <torvalds@linux-foundation.org> > CC: Oleg Nesterov <oleg@redhat.com> > CC: Borislav Petkov <bp@alien8.de> > CC: "H. Peter Anvin" <hpa@zytor.com> > CC: Andy Lutomirski <luto@amacapital.net> > CC: Frederic Weisbecker <fweisbec@gmail.com> > CC: X86 ML <x86@kernel.org> > CC: Alexei Starovoitov <ast@plumgrid.com> > CC: Will Drewry <wad@chromium.org> > CC: Kees Cook <keescook@chromium.org> > CC: linux-kernel@vger.kernel.org > --- > arch/x86/kernel/entry_64.S | 24 +++++++++--------------- > 1 file changed, 9 insertions(+), 15 deletions(-) > > diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S > index aacfa2c..71036fe 100644 > --- a/arch/x86/kernel/entry_64.S > +++ b/arch/x86/kernel/entry_64.S > @@ -1365,19 +1365,7 @@ ENTRY(error_exit) > CFI_ENDPROC > END(error_exit) > > -/* > - * Test if a given stack is an NMI stack or not. > - */ > - .macro test_in_nmi reg stack nmi_ret normal_ret > - cmpq %\reg, \stack > - ja \normal_ret > - subq $EXCEPTION_STKSZ, %\reg > - cmpq %\reg, \stack > - jb \normal_ret > - jmp \nmi_ret > - .endm > - > - /* runs on exception stack */ > +/* Runs on exception stack */ > ENTRY(nmi) > INTR_FRAME > PARAVIRT_ADJUST_EXCEPTION_FRAME > @@ -1438,8 +1426,14 @@ ENTRY(nmi) > * We check the variable because the first NMI could be in a > * breakpoint routine using a breakpoint stack. > */ > - lea 6*8(%rsp), %rdx > - test_in_nmi rdx, 4*8(%rsp), nested_nmi, first_nmi > + lea 6*8(%rsp), %rdx > + cmpq %rdx, 4*8(%rsp) > + ja first_nmi > + subq $EXCEPTION_STKSZ, %rdx > + cmpq %rdx, 4*8(%rsp) > + jb first_nmi > + jmp nested_nmi > + > CFI_REMEMBER_STATE > > nested_nmi: > -- > 1.8.1.4 >
-- Andy Lutomirski AMA Capital Management, LLC
| |