Messages in this thread | | | Subject | Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions | From | Joe Perches <> | Date | Wed, 09 Dec 2015 15:15:20 -0800 |
| |
On Thu, 2015-12-10 at 01:09 +0200, Andy Shevchenko wrote: > On Thu, Dec 10, 2015 at 12:11 AM, Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches <joe@perches.com> wrote: > > > There are use cases for dumping buffers with specific endian types > > > for 2, 4, and 8 byte variables in arrays. > > > > > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such. > > > > > > Rename groupsize to groupflags in the functions and add documentation > > > to the kernel-doc to describe the use of the DUMP_TYPE_ enum. > > > > One comment below and my tag > > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Couple of additional notes. (Tag still in power) > > 1. There is similar to print_hex_dump() function in seq_file. Separate patch?
Let's see if anyone wants this one first.
> 2. What to do with ASCII part? Shall we print it as byte stream?
It's still emitted as a byte stream.
> And one more style comment below.
That one's a nit I don't care about.
| |