Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check | Date | Thu, 10 Dec 2015 00:38:27 +0100 |
| |
On Wednesday, December 09, 2015 08:53:55 AM Jacob Pan wrote: > On Wed, 9 Dec 2015 08:31:12 -0500 > Prarit Bhargava <prarit@redhat.com> wrote: > > > Intel RAPL initialized on several systems where the BIOS lock bit (msr > > 0x610, bit 63) was set. This occured because the return value of > > rapl_read_data_raw() was being checked, rather than the value of the > > variable passed in, locked. > > > > This patch properly implments the rapl_read_data_raw() call to check > > the variable locked, and now the Intel RAPL driver outputs the > > warning: > > > > intel_rapl: RAPL package 0 domain package locked by BIOS > > > > and does not initialize for the package. > > > > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> > > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> > > Cc: Radivoje Jovanovic <radivoje.jovanovic@intel.com> > > Cc: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com> > > Cc: Mathias Krause <minipli@googlemail.com> > > Cc: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com> > > Signed-off-by: Prarit Bhargava <prarit@redhat.com> > > > > [v2]: fix brackets > > Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
OK, I've put it into my bleeding-edge branch as 4.5 candidate, but do we want it in "stable" and therefore should it be pushed for 4.4?
Thanks, Rafael
| |