lkml.org 
[lkml]   [2015]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs: Drop CAP_SYS_RAWIO requirement for FIBMAP
On Sat, Dec 05, 2015 at 12:15:16AM -0600, Seth Forshee wrote:
> The information exposed by FIBMAP is not privileged and is
> similar to the information provided by FIEMAP, which does not
> require privileges. According to [1] the reason the capability
> check was originally added was to prevent crashing the kernel
> by passing invalid arguments, but this should no longer be a
> problem, so this requirement can be removed.
>
> [1] http://www.gossamer-threads.com/lists/linux/kernel/103611
>
> Cc: "Serge E. Hallyn" <serge@hallyn.com>
> Cc: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>

Acked-by: Serge Hallyn <serge.hallyn@canonical.com>

> ---
> fs/ioctl.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ioctl.c b/fs/ioctl.c
> index 5d01d2638ca5..c963d82b0de8 100644
> --- a/fs/ioctl.c
> +++ b/fs/ioctl.c
> @@ -55,8 +55,6 @@ static int ioctl_fibmap(struct file *filp, int __user *p)
> /* do we support this mess? */
> if (!mapping->a_ops->bmap)
> return -EINVAL;
> - if (!capable(CAP_SYS_RAWIO))
> - return -EPERM;
> res = get_user(block, p);
> if (res)
> return res;
> --
> 1.9.1


\
 
 \ /
  Last update: 2015-12-10 00:01    [W:0.032 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site