lkml.org 
[lkml]   [2015]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ovl: check dentry positiveness in ovl_cleanup_whiteouts()
From
On Mon, Nov 16, 2015 at 4:44 PM, Konstantin Khlebnikov
<khlebnikov@yandex-team.ru> wrote:
> This patch fixes kernel crash at removing directory which contains
> whiteouts from lower layers.
>
> Cache of directory content passed as "list" contains entries from all
> layers, including whiteouts from lower layers. So, lookup in upper dir
> (moved into work at this stage) will return negative entry. Plus this
> cache is filled long before and we can race with external removal.
>
> Example:
> mkdir -p lower0/dir lower1/dir upper work overlay
> touch lower0/dir/a lower0/dir/b
> mknod lower1/dir/a c 0 0
> mount -t overlay none overlay -o lowerdir=lower1:lower0,upperdir=upper,workdir=work
> rm -fr overlay/dir
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Cc: Stable <stable@vger.kernel.org> # 3.18+

Thanks, applied.

Miklos


\
 
 \ /
  Last update: 2015-12-09 23:01    [W:0.035 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site