Messages in this thread | | | Date | Wed, 9 Dec 2015 22:36:58 +0200 | Subject | Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() | From | Andy Shevchenko <> |
| |
On Wed, Dec 9, 2015 at 10:17 PM, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > On Wed, Dec 09 2015, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: >> On Wed, Dec 9, 2015 at 9:28 PM, Joe Perches <joe@perches.com> wrote:
>>> +enum { >>> + DUMP_TYPE_CPU = 0, >> >> And still open this, do we need it? I think you may just mention in >> the documentation that default behaviour is CPU like. > > I think it's best to have a name for the default. In this case it's > unlikely to ever be relevant, but in general one could imagine stuff > like > > #ifdef THIS_OR_THAT > #define MY_DUMP_TYPE DUMP_TYPE_LE > #else > #define MY_DUMP_TYPE DUMP_TYPE_CPU > #endif > > which is a lot more readable than if the latter was a naked 0.
Point taken.
Though _CPU suggests user to think if it's equivalent to BE or LE. I'm wondering if _NATIVE is better?
-- With Best Regards, Andy Shevchenko
| |