lkml.org 
[lkml]   [2015]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] powerpc/nvram: Fix a memory leak in err path
From
Date
On 12/09/2015 04:00 AM, xinhui wrote:
>
> If kmemdup fails, We need kfree *buff* first then return -ENOMEM.
> Otherwise there is a memory leak.
>
> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>

Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>

> ---
> arch/powerpc/kernel/nvram_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c
> index 32e2652..21a278b7 100644
> --- a/arch/powerpc/kernel/nvram_64.c
> +++ b/arch/powerpc/kernel/nvram_64.c
> @@ -542,9 +542,9 @@ static ssize_t nvram_pstore_read(u64 *id, enum pstore_type_id *type,
> time->tv_nsec = 0;
> }
> *buf = kmemdup(buff + hdr_size, length, GFP_KERNEL);
> + kfree(buff);
> if (*buf == NULL)
> return -ENOMEM;
> - kfree(buff);
>
> if (err_type == ERR_TYPE_KERNEL_PANIC_GZ)
> *compressed = true;
>



\
 
 \ /
  Last update: 2015-12-09 16:41    [W:1.368 / U:1.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site