Messages in this thread | | | Date | Wed, 9 Dec 2015 08:09:46 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v5 08/11] ARM: STi: Register CPUFreq device |
| |
On 08-12-15, 14:32, Lee Jones wrote: > +/** > + * SMP Operations > + */
Why do you need a documentation style comment here?
> static void write_pen_release(int val) > { > pen_release = val; > @@ -161,3 +166,11 @@ struct smp_operations __initdata sti_smp_ops = { > .smp_secondary_init = sti_secondary_init, > .smp_boot_secondary = sti_boot_secondary, > }; > + > +/** > + * CPUFreq Registration > + */
Here too.
> +void init_cpufreq(void) > +{ > + platform_device_register_simple("sti-cpufreq", -1, NULL, 0); > +}
I don't think you need this, as you can do all the stuff you want from the module_init() function in the driver. You just have to make sure that your driver is only compilable and workable on the right STi platform.
-- viresh
| |