Messages in this thread | | | Subject | Re: [PATCH] net: emac: emac gigabit ethernet controller driver | From | Felix Fietkau <> | Date | Tue, 8 Dec 2015 00:33:04 +0100 |
| |
On 2015-12-07 23:58, Gilad Avidov wrote: > +/* RRD (Receive Return Descriptor) */ > +union emac_rrd { > + struct { > + /* 32bit word 0 */ > + u32 xsum:16; > + u32 nor:4; /* number of RFD */ > + u32 si:12; /* start index of rfd-ring */ > + /* 32bit word 1 */ > + u32 hash; > + /* 32bit word 2 */ You should never use bitfields for hardware structs. I think in general, kernel code should be made endian safe, even if you only care about one particular endian type for your platform.
- Felix
| |