lkml.org 
[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] clear file privilege bits when mmap writing
From
On Thu, Dec 3, 2015 at 5:45 PM, yalin wang <yalin.wang2010@gmail.com> wrote:
>
>> On Dec 2, 2015, at 16:03, Kees Cook <keescook@chromium.org> wrote:
>>
>> Normally, when a user can modify a file that has setuid or setgid bits,
>> those bits are cleared when they are not the file owner or a member
>> of the group. This is enforced when using write and truncate but not
>> when writing to a shared mmap on the file. This could allow the file
>> writer to gain privileges by changing a binary without losing the
>> setuid/setgid/caps bits.
>>
>> Changing the bits requires holding inode->i_mutex, so it cannot be done
>> during the page fault (due to mmap_sem being held during the fault).
>> Instead, clear the bits if PROT_WRITE is being used at mmap time.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> Cc: stable@vger.kernel.org
>> —
>
> is this means mprotect() sys call also need add this check?
> mprotect() can change to PROT_WRITE, then it can write to a
> read only map again , also a secure hole here .

Yes, good point. This needs to be added. I will send a new patch. Thanks!

-Kees

--
Kees Cook
Chrome OS & Brillo Security


\
 
 \ /
  Last update: 2015-12-08 00:01    [W:0.930 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site