lkml.org 
[lkml]   [2015]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v4 14/24] clk: pwm: use pwm_get/set_default_xxx() helpers where appropriate
    Date
    Hi Boris,

    Quoting Boris Brezillon (2015-11-16 00:56:37)
    > pwm_set/get_default_xxx() helpers have been introduced to differentiate
    > the default PWM states (those retrieved through DT, PWM lookup table or
    > statically assigned by the driver) and the current ones.
    > Make use of those helpers where appropriate.
    >
    > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
    > ---
    > drivers/clk/clk-pwm.c | 12 ++++++------
    > 1 file changed, 6 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/clk/clk-pwm.c b/drivers/clk/clk-pwm.c
    > index b6306a2..642a49a 100644
    > --- a/drivers/clk/clk-pwm.c
    > +++ b/drivers/clk/clk-pwm.c
    > @@ -71,23 +71,23 @@ static int clk_pwm_probe(struct platform_device *pdev)
    > if (IS_ERR(pwm))
    > return PTR_ERR(pwm);
    >
    > - if (!pwm_get_period((pwm))) {
    > + if (!pwm_get_default_period((pwm))) {

    The change itself looks fine, but the semantic patch added extra parens.
    Can you remove them? After doing so feel free to add:

    Acked-by: Michael Turquette <mturquette@baylibre.com>


    \
     
     \ /
      Last update: 2015-12-30 22:21    [W:2.642 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site