lkml.org 
[lkml]   [2015]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction
From
On Wed, Dec 30, 2015 at 3:23 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
> On 12/9/2015 12:14 PM, Christopher Covington wrote:
>>> On 12/9/2015 11:59 AM, Andy Shevchenko wrote:

>>>>> + if (trigger != ACPI_MADT_TRIGGER_LEVEL ||
>>>>>> + polarity != ACPI_MADT_POLARITY_ACTIVE_LOW)
>>>>>> + penalty = PIRQ_PENALTY_ISA_ALWAYS;
>>>>>> + else
>>>>>> + penalty = PIRQ_PENALTY_PCI_USING;
>>>>>> +
>>>>>> + acpi_irq_add_penalty(irq, penalty);

>>>> Why not to change in place? I think a common sense rule is not to
>>>> change something existing if it doesn't add any significant value.

>>>> - acpi_irq_penalty[irq] += PIRQ_PENALTY_PCI_USING;
>>>> + acpi_irq_add_penalty(irq, PIRQ_PENALTY_PCI_USING);
>>
>> I think Andy was suggesting that you make the change without introducing
>> the penalty variable.

> Is Chris' interpretation correct?

Yep, I meant not to use an additional variable.

> BTW, I suggest you spend some time around checkpatch for contributions. I could
> have caught most of the issues you are generally concerned before submitting a patch.

Is it a question?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2015-12-30 15:21    [W:0.197 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site