Messages in this thread | | | Date | Thu, 03 Dec 2015 16:43:28 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCH] PCI: MSI: Only use the generic MSI layer when domain is hierarchical |
| |
On 23/11/15 17:38, Thomas Gleixner wrote: > On Mon, 23 Nov 2015, Marc Zyngier wrote: > >> Since d8a1cb757550 ("PCI/MSI: Let pci_msi_get_domain use struct >> device::msi_domain"), we use the MSI domain associated to the PCI device. >> >> But finding a MSI domain doesn't mean that the domain is implemented >> using the generic MSI domain API, and a number of MSI controllers >> are still using the arch_setup_msi_irq/arch_teardown_msi_irqs. >> >> In order to avoid a firework on these systems, check that the domain >> we just obtained is hierarchical. If not, don't use the generic MSI >> stuff and stick with the old one. Not pretty, but reliable. >> >> Another insentive to rework those drivers and phase out this API. >> >> Reported-by: Phil Edworthy <phil.edworthy@renesas.com> >> Tested-by: Phil Edworthy <phil.edworthy@renesas.com> >> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > > Acked-by: Thomas Gleixner <tglx@linutronix.de> >
Hi Bjorn,
Do you have any objection to taking this patch? It fixes a real issue for drivers not using the generic MSI domains.
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |