lkml.org 
[lkml]   [2015]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] usb: gadget: f_midi: refactor state machine
Date

Hi,

"Felipe F. Tonello" <eu@felipetonello.com> writes:
> This refactor includes the following:
> * Cleaner state machine code;
> * Reset state if MIDI message parsed is non-conformant;
> * Fixed bug when a conformant MIDI message was followed by a non-conformant
> causing the MIDI-USB message to use old temporary data (port->data[0..1]),
> thus packing a wrong MIDI-USB request.

we don't do more than one logical thing per patch. Please split this up.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-12-22 19:01    [W:0.153 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site