Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH 1/2] usb: gadget: f_midi: refactor state machine | Date | Tue, 22 Dec 2015 11:49:06 -0600 |
| |
Hi,
"Felipe F. Tonello" <eu@felipetonello.com> writes: > This refactor includes the following: > * Cleaner state machine code; > * Reset state if MIDI message parsed is non-conformant; > * Fixed bug when a conformant MIDI message was followed by a non-conformant > causing the MIDI-USB message to use old temporary data (port->data[0..1]), > thus packing a wrong MIDI-USB request.
we don't do more than one logical thing per patch. Please split this up.
-- balbi [unhandled content-type:application/pgp-signature]
| |