lkml.org 
[lkml]   [2015]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/4] ASoC: omap-hdmi-audio: add NULL test
From
Date
On 12/20/2015 01:15 PM, Julia Lawall wrote:
> Add NULL test on call to devm_kzalloc.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x;
> identifier fld;
> @@
>
> * x = devm_kzalloc(...);
> ... when != x == NULL
> x->fld
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> ---
> sound/soc/omap/omap-hdmi-audio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-audio.c
> index 584b237..f83cc2b 100644
> --- a/sound/soc/omap/omap-hdmi-audio.c
> +++ b/sound/soc/omap/omap-hdmi-audio.c
> @@ -368,6 +368,8 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
> card->owner = THIS_MODULE;
> card->dai_link =
> devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);
> + if (!card->dai_link)
> + return -ENOMEM;
> card->dai_link->name = card->name;
> card->dai_link->stream_name = card->name;
> card->dai_link->cpu_dai_name = dev_name(ad->dssdev);
>


--
Péter


\
 
 \ /
  Last update: 2015-12-21 11:01    [W:0.084 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site