lkml.org 
[lkml]   [2015]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events
Hi Jiri,

On Sun, Dec 20, 2015 at 02:51:32PM +0100, Jiri Olsa wrote:
> On Wed, Dec 16, 2015 at 12:35:38AM +0900, Namhyung Kim wrote:
>
> SNIP
>
> > +
> > + if (!len)
> > + len = hde_width(hde);
> > +
> > + return len;
> > +}
> > +
> > +static int __sort__hde_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> > + struct hist_entry *he)
> > +{
> > + struct hpp_dynamic_entry *hde;
> > + size_t len = fmt->user_len;
> > + struct trace_seq seq;
> > + int ret;
> > +
> > + hde = container_of(fmt, struct hpp_dynamic_entry, hpp);
> > +
> > + if (!len)
> > + len = hde_width(hde);
> > +
> > + if (hists_to_evsel(he->hists) != hde->evsel)
> > + return scnprintf(hpp->buf, hpp->size, "%*.*s", len, len, "N/A");
>
> hum, how can this happen? ... "hists_to_evsel(he->hists) != hde->evsel"

If there's more than one event, a dynamic sort key is defined for one
event. So other events should not be affected by the sort key and
show "N/A" in the output.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2015-12-20 15:21    [W:0.046 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site