lkml.org 
[lkml]   [2015]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [char-misc-next 4/7] watchdog: mei_wdt: add status debugfs entry
Date


> >>> +#if IS_ENABLED(CONFIG_DEBUG_FS)
> >>> +static const char *mei_wdt_state_str(enum mei_wdt_state state)
> >>> +{
> >>> + switch (state) {
> >>> + case MEI_WDT_IDLE: return "IDLE";
> >>> + case MEI_WDT_START: return "START";
> >>> + case MEI_WDT_RUNNING: return "RUNNING";
> >>> + case MEI_WDT_STOPPING: return "STOPPING";
> >>> + default: return "unknown";
> >>
> >> Doesn't this cause checkpatch warnings ?
> > It doesn't and also checkpatch.pl is just a help tool.
>
> I should have said "Doesn't this violate the single-statement-per-line"
> coding style rule, but I guess then you'd argue that "case xxx:" is not
> a statement.

I believe it is reasonably readable , but I don't have a strong feeling about it, if you do I can change it.

Tomas



\
 
 \ /
  Last update: 2015-12-20 13:21    [W:0.130 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site