lkml.org 
[lkml]   [2015]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 142/164] ALSA: bebob: use correct type for __be32 data
    Date
    3.19.8-ckt11 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Sakamoto <o-takashi@sakamocchi.jp>

    commit fef586d58960bc867c1fa8126ee5d7364a5a89ac upstream.

    In former commit, metering is supported for BeBoB based models
    customized by M-Audio. The data in transaction is aligned to
    big-endianness, while in the driver code u16 typed variable is assigned
    to the data. This causes sparse warnings.

    bebob_maudio.c:651:31: warning: cast to restricted __be16
    bebob_maudio.c:651:31: warning: cast to restricted __be16
    bebob_maudio.c:651:31: warning: cast to restricted __be16
    bebob_maudio.c:651:31: warning: cast to restricted __be16

    This commit fixes this bug by using __be16 variable for the data.

    Fixes: 3149ac489ff8('ALSA: bebob: Add support for M-Audio special Firewire series')
    Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    sound/firewire/bebob/bebob_maudio.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/firewire/bebob/bebob_maudio.c b/sound/firewire/bebob/bebob_maudio.c
    index 9ee25a6..fc7af1c 100644
    --- a/sound/firewire/bebob/bebob_maudio.c
    +++ b/sound/firewire/bebob/bebob_maudio.c
    @@ -619,7 +619,7 @@ static const char *const special_meter_labels[] = {
    static int
    special_meter_get(struct snd_bebob *bebob, u32 *target, unsigned int size)
    {
    - u16 *buf;
    + __be16 *buf;
    unsigned int i, c, channels;
    int err;

    --
    1.9.1


    \
     
     \ /
      Last update: 2015-12-02 18:21    [W:5.132 / U:0.720 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site