lkml.org 
[lkml]   [2015]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/9] rmap: support file THP
On Tue, Dec 01, 2015 at 12:56:13PM -0800, Dave Hansen wrote:
> On 11/18/2015 03:25 PM, Kirill A. Shutemov wrote:
> > -void page_add_file_rmap(struct page *page)
> > +void page_add_file_rmap(struct page *page, bool compound)
>
> I take it we have to pass 'compound' in explicitly because
> PageCompound() could be true, but we don't want to do a compound
> mapping. This is true for those weirdo sound driver allocations and a
> few other ones, right?

Right. Also more common case will be PTE-mapped THPs as we have now for
anon-THP.

Basically, we mirror what was done for anon rmap interface.

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2015-12-16 13:21    [W:0.079 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site