lkml.org 
[lkml]   [2015]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 4/5] iommu/mediatek: Add mt8173 IOMMU driver
From
Date
On Mon, 2015-12-14 at 19:19 +0100, Matthias Brugger wrote:
>
> On 08/12/15 10:49, Yong Wu wrote:
> > This patch adds support for mediatek m4u (MultiMedia Memory Management
> > Unit).
> >
> > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> > ---
[...]
> > +static void mtk_iommu_config(struct mtk_iommu_data *data,
> > + struct device *dev, bool enable)
> > +{
> > + struct mtk_iommu_client_priv *head, *cur, *next;
> > +
> > + head = dev->archdata.iommu;
> > + list_for_each_entry_safe(cur, next, &head->client, client) {
> > + mtk_smi_config_port(
> > + data->larbdev[MTK_M4U_TO_LARB(cur->mtk_m4u_id)],
> > + MTK_M4U_TO_PORT(cur->mtk_m4u_id), enable);
>
> Use an extra variable for MTK_M4U_TO_LARB(cur->mtk-m4u_id), this makes
> the code easier to read.

OK. Thanks.
I will fix it in next version.

>
> Regards,
> Matthias
>
> > + }
> > +}
> > +
[...]




\
 
 \ /
  Last update: 2015-12-15 04:01    [W:0.137 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site