Messages in this thread | | | From | Kuninori Morimoto <> | Subject | Re: [PATCH 4/8 v4] thermal: rcar: retern error rcar_thermal_get_temp() if no ctemp update | Date | Tue, 15 Dec 2015 00:24:45 +0000 |
| |
Hi Eduardo, again
> I believe the problem here is actually the lack of error > handling/propagation. Are you sure you want to write to parameter > in the fail path ? > > rcar_thermal_update_temp already returns error code when it fails > to read temperature. Don't you think it would make more sense to fix the > places that call rcar_thermal_update_temp to properly handle its return > value and propagate that error code when necessary?
Will update in v5
| |