lkml.org 
[lkml]   [2015]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty/n_gsm.c: fix false positive WARN_ON and do some codes improvement
On Wed, Nov 25, 2015 at 07:18:37PM +0800, xinhui wrote:
> From: xinhui <xinhui@linux.vnet.ibm.com>
>
> If gsm driver fails to activate one mux, and this mux is not stored in
> gsm_mux[], there would be a warning in gsm_cleanup_mux(). Actually this
> is a legal case. So just do a simple check instead of WARN_ON.
>
> There is one filed gsm->num to store its index of gsm_mux[]. So use
> gsm->num to remove itself from gsm_mux[] instead of the for-loop
> traverse.
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Fixes: 5a64096700dc ("tty/n_gsm.c: fix a memory leak in gsmld_open")
> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>

the signed-off-by name has to match your from: name :(


\
 
 \ /
  Last update: 2015-12-14 23:01    [W:0.397 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site