Messages in this thread | | | Subject | Re: [PATCH v2] PCI/AER: enable SERR# forwarding for bridges and switches | From | Sinan Kaya <> | Date | Mon, 14 Dec 2015 13:22:39 -0500 |
| |
On 12/11/2015 6:30 PM, Sinan Kaya wrote: >> I think the best way to fix all the cases would be to do something in >> > in pci_configure_device(). Then we could drop the AER bus walk in >> > set_downstream_devices_error_reporting(). A bus walk like that is >> > always an issue for hotplug. >> > > Let me read some code. >
OK, If I understand it right; pci_configure_device is where program_hpp_type0 called. You also want to enable AER in this function.
Move the contents of set_device_error_reporting into pci_configure_device like this below ?
... + int type = pci_pcie_type(dev);
pci_configure_mps(dev);
+ if ((type == PCI_EXP_TYPE_ROOT_PORT) || + (type == PCI_EXP_TYPE_UPSTREAM) || + (type == PCI_EXP_TYPE_DOWNSTREAM)) { + pci_enable_pcie_error_reporting(dev); + }
+ pcie_set_ecrc_checking(dev);
-- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |